-
Notifications
You must be signed in to change notification settings - Fork 38
Clarify parity swap procedure #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the documentation for the Parity Swap procedure. The instructions now clearly outline the process: stopping the array, unassigning the current parity drive, optionally removing the physical drive, adding and assigning the new drive, and finally starting the array to trigger the parity-sync process. Outdated version-specific notes and cautions have been removed to improve clarity. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant A as Array/System
participant D as Documentation
U->>D: Read updated Parity Swap instructions
U->>A: Stop array
U->>A: Unassign current parity drive
U->>A: (Optional) Physically remove current parity drive
U->>A: Add & assign new parity drive
U->>A: Start array (initiates parity-sync process)
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/legacy/FAQ/parity-swap-procedure.md (1)
49-52
: Clarify Physical Removal Step and Correct Typo
The updated steps now clearly indicate that the current parity drive can optionally be physically removed before adding the new drive. However, there is a typographical error in the phrase “Start the array to being the parity-sync process.” It should read “Start the array to begin the parity-sync process.”-Start the array to being the parity-sync process. The array will remain available during this but accessing it will be slower than normal. +Start the array to begin the parity-sync process. The array will remain available during this process, though with slower access speeds.
Before Submitting This PR, Please Ensure You Have Completed The Following:
Summary by CodeRabbit