Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

feature: separate action bar renderer #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tmarcinkowski-logitech
Copy link
Contributor

@tmarcinkowski-logitech tmarcinkowski-logitech commented Jun 19, 2021

Description

I have extracted existing markup wrapping both actions and filtered rendered into separate ActionBar renderer. I needed more flexibility to style this the way I wanted.

Changelog

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Manually - I integrated the component with my codebase and I check both default behavior, just as the new one - using custom acionbar renderer

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation [there is no documentation]
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (there are no tests)
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@dreadera
Copy link
Contributor

Hello 👋

I'd like for all PRs to follow a template going forward to help with keeping track :)
You can find the template here.

Other then that the PR name format should be the following.
feature: feature description
fix: fix description

@tmarcinkowski-logitech tmarcinkowski-logitech changed the title separate action bar renderer feature: separate action bar renderer Jun 21, 2021
@tmarcinkowski-logitech
Copy link
Contributor Author

Hello 👋

I'd like for all PRs to follow a template going forward to help with keeping track :)
(...)

I've updated all my PRs ;)

BTW you're sure you mean feature (full wording) instead of feat like in Conventional Commits?

@dreadera
Copy link
Contributor

Thank you 🔥 and I prefer feature but you could also do feat as long as the PR title follows the same format :)

@dreadera dreadera self-requested a review June 21, 2021 06:38
@dreadera dreadera removed their request for review February 1, 2022 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants