Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage #191

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Fix coverage #191

merged 10 commits into from
Oct 8, 2024

Conversation

ivojawer
Copy link
Contributor

@ivojawer ivojawer commented Oct 8, 2024

  • Agrego un codecov.yml que setupea components (lo que antes eran flags)
  • Correr tests para que tome los subprocesos
    • Usa @vscode/test-cli para correr los tests e2e
    • Usa c8 para para correr los unit tests
  • El coverage se handlea solo en package.json root, asi no hay que tenerlo en cuenta desde los packages

@ivojawer ivojawer marked this pull request as ready for review October 8, 2024 22:01
@ivojawer
Copy link
Contributor Author

ivojawer commented Oct 8, 2024

No tengo ni idea de por que pero localmente me recopila el coverage del debugger y en el CI no.

-----------------------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------
File                                     | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-----------------------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------
All files                                |   90.95 |    80.68 |   89.07 |   90.95 |
 client/src                              |   92.46 |    67.56 |   83.33 |   92.46 |
  commands.ts                            |   96.15 |    57.69 |     100 |   96.15 | 89-90,112-114
  extension.ts                           |   97.47 |     87.5 |      75 |   97.47 | 95-97
  platform-string-utils.ts               |   58.82 |      100 |   66.66 |   58.82 | 11-17
  shared-definitions.ts                  |     100 |      100 |     100 |     100 |
  utils.ts                               |      50 |      100 |      50 |      50 | 8-14
 client/src/test                         |   86.15 |     87.5 |   85.71 |   86.15 |
  helper.ts                              |   86.15 |     87.5 |   85.71 |   86.15 | 34-36,56-61
 debug-adapter/src                       |   81.21 |    79.26 |   65.51 |   81.21 |
  debug-configuration-provider.ts        |   25.92 |      100 |       0 |   25.92 | 7-26
  debug-session.ts                       |   85.67 |    78.48 |   69.56 |   85.67 | ...07-115,124-126,154-155,174-175,178-180,183-185,188-190,193-195,267-270,299,305
  index.ts                               |     100 |      100 |   66.66 |     100 |
  session-factory.ts                     |   71.42 |      100 |      50 |   71.42 | 10-13
 debug-adapter/src/test                  |     100 |      100 |     100 |     100 |
  start-debug-session.ts                 |     100 |      100 |     100 |     100 |
 server/src                              |   83.59 |    73.77 |    90.9 |   83.59 |
  linter.ts                              |   73.78 |    78.57 |      80 |   73.78 | 68-69,79-103
  server.ts                              |   79.71 |       64 |      75 |   79.71 | ...27-132,139-141,148-149,167-181,183-184,195-196,221-222,230-231,245-248,263-275
  settings.ts                            |     100 |     62.5 |     100 |     100 | 23-24,53
  shared-definitions.ts                  |     100 |      100 |     100 |     100 |
  time-measurer.ts                       |     100 |    92.85 |     100 |     100 | 14
 server/src/functionalities              |   94.75 |    79.36 |   94.87 |   94.75 |
  code-lens.ts                           |   99.02 |    84.37 |     100 |   99.02 | 20
  definition.ts                          |      80 |    72.72 |   66.66 |      80 | 18-20,33-34,38-41
  formatter.ts                           |   86.04 |    83.33 |     100 |   86.04 | 8-11,40-41
  hover.ts                               |   86.48 |       50 |     100 |   86.48 | 15-16,34-36
  references.ts                          |   82.35 |       80 |     100 |   82.35 | 9-11
  rename.ts                              |   96.96 |    79.16 |     100 |   96.96 | 28-29
  reporter.ts                            |   99.22 |       80 |     100 |   99.22 | 228-229
  symbols.ts                             |    92.5 |    83.33 |     100 |    92.5 | 11-13,62,70,72
 server/src/functionalities/autocomplete |   98.74 |    82.88 |     100 |   98.74 |
  autocomplete.ts                        |   96.49 |       75 |     100 |   96.49 | 18-20,25-27
  node-completion.ts                     |     100 |     87.8 |     100 |     100 | 29-31,46,71,86
  options-autocomplete.ts                |     100 |      100 |     100 |     100 |
  send-completion.ts                     |     100 |     90.9 |     100 |     100 | 10,41
 server/src/test/mocks                   |     100 |      100 |     100 |     100 |
  file-contents.ts                       |     100 |      100 |     100 |     100 |
 server/src/test/utils                   |     100 |      100 |     100 |     100 |
  wollok-test-utils.ts                   |     100 |      100 |     100 |     100 |
 server/src/utils                        |   94.73 |    94.82 |   91.66 |   94.73 |
  logger.ts                              |     100 |      100 |     100 |     100 |
  progress-reporter.ts                   |   91.66 |      100 |      80 |   91.66 | 14-15
  strings.ts                             |     100 |      100 |     100 |     100 |
  text-documents.ts                      |   94.03 |    93.47 |   94.44 |   94.03 | 105,144-151
 server/src/utils/vm                     |   89.79 |    71.42 |     100 |   89.79 |
  environment.ts                         |   89.79 |    71.42 |     100 |   89.79 | 40-44
-----------------------------------------|---------|----------|---------|---------|-----------------------------------------------------------------------------------

Pero bueno, al menos ahora funciona como antes

@ivojawer ivojawer requested review from fdodino and PalumboN October 8, 2024 22:08
Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdodino fdodino merged commit 6cb2a33 into master Oct 8, 2024
9 checks passed
@fdodino fdodino deleted the fix-coverage branch October 8, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants