feat(command): show global options in command help #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlackHole1
force-pushed
the
add-global-options
branch
from
366f717
to
a55fd0b
Compare
If there are persistent flags, they should also be displayed in the command. Signed-off-by: Kevin Cui <[email protected]>
BlackHole1
force-pushed
the
add-global-options
branch
from
a55fd0b
to
69753e8
Compare
Juneezee
reviewed
Jul 9, 2024
Co-authored-by: Eng Zer Jun <[email protected]>
Signed-off-by: Kevin Cui <[email protected]>
Juneezee
approved these changes
Jul 9, 2024
|
Friendly ping :) |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are persistent flags, they should also be displayed in the command.
What type of PR is this?
What this PR does / why we need it:
If there is a persistent flag named foo and
Required: true, the user will not see this flag when executingcmd subCommand --help, but an error will be reported if the user does not provide this flag. This will cause confusion for the user.Which issue(s) this PR fixes:
Close #734
Special notes for your reviewer:
Does the
VisiblePersistentFlagsfunction need to handle the case ofMutuallyExclusiveFlagsinternally?Testing
go test -run=TestShowSubcommandHelp_GlobalOptionsRelease Notes
/cc @dearchap