Revert "Add TakesFile indicator to flag"
#858
Conversation
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 18 18
Lines 2362 2362
=======================================
Hits 1685 1685
Misses 572 572
Partials 105 105
Continue to review full report at Codecov.
|
|
@AudriusButkevicius can you give a more thorough explanation of why you're opening this PR? I don't have enough context to make a decision here. |
|
If we want to revert this, I think the reversion needs to come with a thorough explanation in the PR description. I don't understand why would should be reverting this, which means I am very likely to unknowingly approve similar changes like this in the future. If there's some API stability north star we are working towards, then it would help me out if that north star was described. My current state is that I have no idea why someone would / would not add a certain feature, and I need to be educated on this if the goal is for me to make decisions that move the API to a good place. |
|
Let's first finalize the discussion on #851 and then come to a conclusion about whether or not this PR is even necessary |
|
The rationale is on the original PR that this is reverting. |
|
I consider this PR blocked pending more discussion, similarly to #860 |
|
We can probably close this and merge #860 before we release anything. |
👍 |
Reverts #851
Suggest we rethink this before this spreads too far.