fix stof error #5
Conversation
There was a problem hiding this comment.
@JunseoMin Oh man appericate you having your warm and kind attention!
Could you consider my comments and push a commit again?
| while (std::getline(ifs, line)) { | ||
| if (line.empty()) continue; |
There was a problem hiding this comment.
Does this situation occur in the current pipeline?
There was a problem hiding this comment.
Nope. This situation does not occur in the current pipeline.
include/SE2posemanager.hpp
Outdated
| while (std::getline(ifs, line)) { | ||
| if (line.empty()) continue; | ||
| float x,y,yaw; |
There was a problem hiding this comment.
Why do we need to declare unused variables here?
There was a problem hiding this comment.
These two lines (28,29) were only used for debugging, and I accidentally forgot to remove them. Thanks for checking!
include/SE2posemanager.hpp
Outdated
|
|
||
| if (words.size() < 4) { | ||
| std::cerr << "Skipping invalid line: " << line << std::endl; | ||
| continue; |
There was a problem hiding this comment.
Is it okay to use continue? Wouldn't it be better to throw std::logic_error and provide guidance to the user on what went wrong?
|
Again, thanks for your attention, @JunseoMin! By any chance, do you plan to use ORORA in ROS2 in your lab? If so, I'm always open to discussing it! |
|
Thanks for reviewing! I'm interested in radar single-shot localization, but I need to discuss it with my professor first. (I'm currently doing an internship.) If I start researching with ORORA, can I reach out to you via email? |
|
As a kind of fan of yours, I really appreciate your response! For summery:
|
Hi , @LimHyungTae
Thank you for all your amazing contributions! I’ve been following your work on GitHub, LinkedIn, and through your papers.
While running ORORA with the Mulran dataset (sequence DDC01), I encountered an error in the
loadGTPosesfunction withininclude/SE2posemanager.hpp. The error was:After some investigation, I discovered that the issue occurs because the
radar_odometry.csvfile contains the value1.43493e-42. To handle this properly, I changed the conversion fromstoftostod.Additionally, I noticed that the vector
parsed_xyyawwas mistakenly parsing the yaw value twice (usingwords[3]for both y and yaw). I corrected it so that it now properly reads x, y, and yaw:I’ve also added a few safety functions to improve robustness.
Thank you for taking the time to review these changes. I’m really excited to contribute to a codebase by someone I truly admire!
Best regards,
Junseo Min