Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Allow ref in neeuml to handle need parts #1222

Merged

Conversation

PhilipPartsch
Copy link
Contributor

try to solve #1221

@PhilipPartsch
Copy link
Contributor Author

@chrisjsewell and @danwos : I believe this PR can be merged

@chrisjsewell
Copy link
Member

Heya, this makes sense, but bare with me on the review

@chrisjsewell chrisjsewell force-pushed the needuml_enable_needpart_in_ref branch 2 times, most recently from 82db332 to b8f1331 Compare October 8, 2024 16:24
@chrisjsewell chrisjsewell force-pushed the needuml_enable_needpart_in_ref branch from b8f1331 to c8e04d0 Compare October 8, 2024 16:28
Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased, then made some simplifications

@chrisjsewell chrisjsewell changed the title Enable referencing to needpart in ref function in needuml.py 👌 Allow ref in neeuml to handle need parts Oct 8, 2024
@chrisjsewell chrisjsewell merged commit fa937f2 into useblocks:master Oct 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants