This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Fix bug with JSONDecodeError; add retries; fix iteration when collection is changing #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplejson and json diverged a long time ago * attempt to iterate
This was referenced Aug 20, 2018
jdufresne
reviewed
Sep 10, 2018
| 'pycrypto', | ||
| 'pytz', | ||
| 'PyYAML', | ||
| 'requests', | ||
| 'future', | ||
| 'simplejson', |
There was a problem hiding this comment.
Instead of reintroducing the simplejson dependency -- which was intentionally removed -- could we instead fix the bug to work with the stdlib json module?
There was a problem hiding this comment.
that would definitely be a better approach but i'm not sure i will have time to make the change personally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines #19 and #18 with added retry logic for
RateLimitExceededand other API errors.Collection- either via the API or via the GUI - and thetotal_recordsin the response changes, you will always hit an unexplainedIndexErrorat the end of you iteration. This PR should fix that in most cases - you can still iterate, but it will stop without raising IndexError.simplejsonandjsondiverged a long time ago. The json.JSONDecodeError line is now incorrect and bombs out on an AttributeError when trying to catch exceptions.