Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #83

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix broken link #83

merged 1 commit into from
Nov 6, 2024

Conversation

rosskarchner
Copy link
Contributor

The URL for the component definition tutorial is missing the "/implementation/" directory.
@iMichaela
Copy link
Contributor

@rosskarchner - Thank you for submitting a PR that fixes the broken links. Can you please change the base and submit it again the develop branch. Thank you.

@iMichaela iMichaela changed the base branch from main to develop November 6, 2024 01:19
@iMichaela iMichaela self-requested a review November 6, 2024 01:19
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased the PR and reviewed it. It looks good to me.

@iMichaela iMichaela merged commit c19b4a2 into usnistgov:develop Nov 6, 2024
4 checks passed
@rosskarchner
Copy link
Contributor Author

I swear I saw a direction somewhere to open PR's against main-- but I don't see it now, so maybe I'm just crazy ;)

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants