Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom classes hint string #678

Merged

Conversation

chippmann
Copy link
Contributor

Resolves #658

This fixes the generated type hint for custom classes extending resource types and node types.

With normal registration this did not cause any issues but with fqdn registration it did as not the fqdn name was used as a hint string but the simple name.

Important: this does NOT solve the same issue for libraries! If a library registeres a custom resource with fqdn registration enabled but the users project uses normal registration, it uses normal registration. The users project config always overrides the config of any library used. This issue is not as easy solveable atm and i first need to think of a proper solution. This PR fixes the issue at hand though. I created a follow up issue here: #677

@chippmann chippmann added bug Something isn't working topic:entry-gen labels Aug 31, 2024
@chippmann chippmann requested review from CedNaru and piiertho August 31, 2024 14:57
@chippmann chippmann merged commit a37b893 into master Sep 1, 2024
55 checks passed
@chippmann chippmann deleted the bugfix/fix-registered-type-name-for-custom-resources branch September 1, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:entry-gen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom resource classes with FQN is not usable in the Godot editor
3 participants