Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Sort permit past applications #378

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[Improvement] Sort permit past applications #378

merged 4 commits into from
Nov 25, 2024

Conversation

jennchenn
Copy link
Contributor

Notion ticket link

Reorder permit listings to show the most recent permit requests at the top

Implementation description

  • Sort past applications by creation timestamp in permit holder page

Notes

  • Did we want to sort by another dimension (updates? by type?)

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@jennchenn jennchenn self-assigned this Oct 15, 2024
sherryhli
sherryhli approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please fix the lint error?

ChinemeremChigbo
ChinemeremChigbo requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the following changes in app-history.ts

image

ChinemeremChigbo
ChinemeremChigbo approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, lgtm

@jennchenn jennchenn merged commit cda8848 into staging Nov 25, 2024
1 check passed
@jennchenn jennchenn deleted the jenn/sort-permit-apps branch November 25, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinemeremChigbo ChinemeremChigbo ChinemeremChigbo approved these changes

@sherryhli sherryhli sherryhli approved these changes

Assignees

@jennchenn jennchenn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennchenn @ChinemeremChigbo @sherryhli