Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #484 - Remove discriminators from leaderboard #485

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

justin-ys
Copy link
Contributor

@justin-ys justin-ys commented Jun 14, 2023

Summary of Changes

  • Removes the fake #0 discriminator from users that have been assigned a Discord user id. Those that still have discriminators will keep them in the leaderboard.

Motivation and Explanation

  • Discord recently started migrating users with discriminators after their username to unique user IDs.

Related Issues

Steps to Reproduce

  • Run .coin leaderboard with a mix of users that have discriminators and those who don't.

Copy link
Collaborator

@mcpenguin mcpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a very small change.

@@ -274,6 +274,7 @@ export class GamesBlackjackCommand extends Command {
// if player has not acted within time limit, consider it as quitting the game
game = await performGameAction(author.id, BlackjackAction.QUIT);
message.reply("you didn't act within the time limit, please start another game!");
if (game) game.stage = BlackjackStage.DONE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoudl this be here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants