Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust SLS files for 15SP7 and systems running higher Python version #10082

Conversation

meaksh
Copy link
Member

@meaksh meaksh commented Mar 28, 2025

What does this PR change?

In SLE15SP7 there is no more python3-salt package, in favor of new python311-salt.

This PR adjusts the internal Uyuni SLS files that are explicitely mentioning python3-salt package to cover this 15SP7 case.

NOTE: in update-salt.sls and mgr_switch_to_venv_minion.sls we cannot use the pythonversion[1] trick to calculate the target package name, as those SLS bits run also for the Salt Bundle, so the target package calculation can be wrong.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/26711
Port(s):
https://github.com/SUSE/spacewalk/pull/26824
https://github.com/SUSE/spacewalk/pull/26825

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@meaksh meaksh requested review from a team and ycedres and removed request for a team March 28, 2025 13:56
Copy link
Contributor

@ycedres ycedres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@meaksh meaksh merged commit aba986a into uyuni-project:master Mar 31, 2025
30 checks passed
@meaksh meaksh deleted the master-add-python311-cases-to--susemanager-sls branch March 31, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants