ImageコンポーネントにJSDocを追加 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook URL: https://uyupun.github.io/official/refactor_248_image/storybook/ |
tyokinuhata
reviewed
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #248
概要
ややこしい
loadingとdecodingに関してJSDoc内で説明を追記しました。また、以下記事参考にdecodingの値はautoとしてブラウザに任せるようにし、loadingは都度Imageコンポーネント使用側で値を設定するよう型を修正しました。https://zenn.dev/ixkaito/articles/deep-dive-into-decoding
記事をまとめると以下の通りでした。
syncとasyncを使い分けても良いが、現状このプロジェクトではautoで事足りるはず