refactor: update date-picker overlay content to use base styles #10087
+12
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/lumo-date-picker-overlay-content-base-styles
branch
from
a7eead7 to
e0c0bb3
Compare
web-padawan
commented
Aug 26, 2025
| } | ||
|
|
||
| :host([dir='rtl']) ::slotted([slot='years'])::before { | ||
| right: 0; | ||
| transform: translate(75%, -50%) rotate(45deg); | ||
| border-bottom-left-radius: var(--lumo-border-radius-s); |
There was a problem hiding this comment.
This was missing for the year indicator triangle in RTL so I added it. Could use rotate: -45deg instead.
web-padawan
force-pushed
the
refactor/lumo-date-picker-overlay-content-base-styles
branch
3 times, most recently
from
693ae31 to
705bd7f
Compare
web-padawan
force-pushed
the
refactor/lumo-date-picker-overlay-content-base-styles
branch
from
705bd7f to
0b2e213
Compare
|
jouni
approved these changes
Aug 28, 2025
web-padawan
deleted the
refactor/lumo-date-picker-overlay-content-base-styles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vaadin-date-picker-overlay-contentLumo CSS to use base styles.Type of change