feat: implement vaadin-markdown component #9023
Conversation
| * @type {string} | ||
| */ | ||
| markdown: { | ||
| type: String, |
There was a problem hiding this comment.
Should this use sync: true for consistency with other components?
There was a problem hiding this comment.
Aren't we mostly using that for the Polymer -> Lit migration. I don't see sync use in the components that have been originally built with LitElement (side-nav, dashboard, card)
There was a problem hiding this comment.
I suppose it could be problematic with the Flow counterpart if setting content doesn't immediately update the content (so that we'd have to wait for it to be updated in ITs)?
| updated(props) { | ||
| super.updated(props); | ||
|
|
||
| renderMarkdownToElement(this, this.markdown); |
There was a problem hiding this comment.
I would add a check for if (props.has('markdown')) just in case. There are no other props in the component but technically theme attribute from ThemePropertyMixin triggers an internal property which causes update.
|
Description
Implement the
<vaadin-markdown>componentType of change
Feature