Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: created new design for blog page #408

Merged
merged 3 commits into from
Nov 8, 2023
Merged

feat: created new design for blog page #408

merged 3 commits into from
Nov 8, 2023

Conversation

ZhmenZH
Copy link
Contributor

@ZhmenZH ZhmenZH commented Oct 31, 2023

No description provided.

@ZhmenZH ZhmenZH self-assigned this Oct 31, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 31, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 367ed89):

https://valor-software-site--pr408-feat-redesign-blog-p-hgadcm4p.web.app

(expires Tue, 14 Nov 2023 12:20:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 62d5e57916ff939ba36fc26c8e91710f09450b38

@Alexveselun
Copy link
Contributor

Alexveselun commented Nov 1, 2023 •
edited
Loading

The Main(First) article picture should be clickable

  1. Open the "/blog" page
  2. Click on the first article picture
    Expected result: the article is opened. The cursor changed the state
    Actual result: the picture is not clickable

image

@Alexveselun
Copy link
Contributor

Related comments:
https://valor-software.slack.com/archives/C01QZBFAMFW/p1699022871496229?thread_ts=1698764215.925059&cid=C01QZBFAMFW

Alexveselun
Alexveselun approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@Alexveselun Alexveselun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing completed. No critical issues were found

@ZhmenZH ZhmenZH merged commit 4a1a4b3 into development Nov 8, 2023
6 checks passed
@ZhmenZH ZhmenZH deleted the feat/redesign-blog-page branch November 8, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexveselun Alexveselun Alexveselun approved these changes

Assignees

@ZhmenZH ZhmenZH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhmenZH @Alexveselun