Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use library for mssql #1007

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

motypi
Copy link
Contributor

@motypi motypi commented Mar 19, 2025

resolves #814

  • new start_mssql function using TDSv7
  • keeps support for TDSv4

@vanhauser-thc
Copy link
Owner

Good that you added the dbclose etc. - but are they needed?
Did you test this?
because it could be that you just need once the dbinit and then can try to auth endless times and be much faster. or maybe there is a limit. or you can only try once ... so please test and report :-)

@motypi
Copy link
Contributor Author

motypi commented Mar 20, 2025

Hey Marc, I did speed tests and I realise that 10x slower than the previous version. Sorry I hadn't tested speed previously. I implemented the change you proposed, but the issue is that the client is sending pre-login requests and doing a handshake with every login attempt, which happens during dbopen(). It seems like the solution should be for me to find a way to authenticate without the handshakes, which doesn't seem to be an option provided by the API. Maybe we could close for now and I come back another time with a workaround?

@motypi
Copy link
Contributor Author

motypi commented Mar 24, 2025

Hi Marc, I made it so that only passwords longer than 30 characters are tested using TDS7. That helps with the speed issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSSQL module has an undocumented username and password length limit
2 participants