-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use library for mssql #1007
base: master
Are you sure you want to change the base?
Use library for mssql #1007
Conversation
Good that you added the dbclose etc. - but are they needed? |
Hey Marc, I did speed tests and I realise that 10x slower than the previous version. Sorry I hadn't tested speed previously. I implemented the change you proposed, but the issue is that the client is sending pre-login requests and doing a handshake with every login attempt, which happens during dbopen(). It seems like the solution should be for me to find a way to authenticate without the handshakes, which doesn't seem to be an option provided by the API. Maybe we could close for now and I come back another time with a workaround? |
Hi Marc, I made it so that only passwords longer than 30 characters are tested using TDS7. That helps with the speed issues! |
resolves #814