Send error event when sending ZFS fails

job/event.go

@@ -7,6 +7,7 @@ const (
 	StartSendingSnapshotEvent    eventemitter.EventType = "start-sending-snapshot"
 	SnapshotSendingProgressEvent eventemitter.EventType = "snapshot-sending-progress"
 	ResumeSendingSnapshotEvent   eventemitter.EventType = "resume-sending-snapshot"
+	SendSnapshotErrorEvent       eventemitter.EventType = "send-snapshot-error"
 	SentSnapshotEvent            eventemitter.EventType = "sent-snapshot"
 	MarkSnapshotDeletionEvent    eventemitter.EventType = "mark-snapshot-deletion"
 	DeletedSnapshotEvent         eventemitter.EventType = "deleted-snapshot"

job/snapshots_send.go

@@ -258,6 +258,8 @@ func (r *Runner) resumeSendSnapshot(client *zfshttp.Client, ds *zfs.Dataset, rem
 		)
 		return true, nil
 	case err != nil:
+		r.EmitEvent(SendSnapshotErrorEvent, fullSnapName, client.Server(), err)
+
 		return false, fmt.Errorf("error resuming send of %s (sent %d bytes in %s): %w",
 			fullSnapName, result.BytesSent, result.TimeTaken, err,
 		)
@@ -326,6 +328,8 @@ func (r *Runner) sendSnapshot(client *zfshttp.Client, send zfshttp.SnapshotSendO
 		)
 		return nil
 	case err != nil:
+		r.EmitEvent(SendSnapshotErrorEvent, send.Snapshot.Name, client.Server(), err)
+
 		return fmt.Errorf("error sending %s@%s (sent %d bytes in %s): %w",
 			send.DatasetName, send.SnapshotName, result.BytesSent, result.TimeTaken, err,
 		)

job/snapshots_send_test.go

@@ -173,8 +173,21 @@ func TestRunner_sendCancelSnapshots(t *testing.T) {
 			sends[0].CancelSend()
 		})
 
+		gotErr := false
+		runner.AddListener(SendSnapshotErrorEvent, func(args ...interface{}) {
+			require.Len(t, args, 3)
+
+			require.Equal(t, sendSnaps[0], args[0])
+			require.Equal(t, "server", args[1])
+			require.Error(t, args[2].(error))
+
+			t.Logf("got error: %#v", args[2])
+			gotErr = true
+		})
+
 		err := runner.sendSnapshots(1)
 		require.ErrorIs(t, err, context.Canceled)
+		require.True(t, gotErr)
 	})
 }