-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated connectField
tests to @testing-library/react
#1301
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1301 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 231 231
Lines 3821 3821
Branches 1029 1029
=======================================
Hits 3617 3617
Misses 82 82
Partials 122 122 ☔ View full report in Codecov by Sentry. |
[undefined, '', ''], | ||
[undefined, 'Schema', 'Schema'], | ||
[undefined, labelB, labelB], | ||
[undefined, undefined, ''], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove those cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created Test
component that use label
as input
props and it couldn't be rendered.
I changed it now to render label
above input
. Rendering label
is based on rendering label
in TextField
in the uniforms-unstyled
. I needed to change works with nested labels
test after this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Is part of #1130
connectField
RTL testsconnectField
testsMain changes compare to
enzyme
tests:when rendered with label
test followinglabelVariants
:is able to set another field value
test, tested value fromobject
tostring
to have the same type in those two fields