Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Documentation of Plugin Limitations #3

Closed
wants to merge 8 commits into from

Conversation

Manuzor
Copy link

@Manuzor Manuzor commented Apr 21, 2018

I've created a couple of examples to show-case some known limitations of this plugin.

I hope you find this useful.

@veelo
Copy link
Owner

veelo commented Apr 21, 2018

Thanks for your contribution, Manuel. I will have a closer look later. On first glance, limitations depend on certain options being passed to the compiler, am I right? Would the linter work correctly if these options were passed to dmd by the linter? If so, I think we should try to pass these options. I take it you are aware of "args", see https://github.com/veelo/SublimeLinter-contrib-dmd#settings?

Apropos limitations, there is also this: #2

@veelo
Copy link
Owner

veelo commented Apr 21, 2018

A quick note: I am not sure it is worth your time to try and make the tests pass. These tests are imposed by the Sublime folks, and apply to the linter plugin itself. Your subdirectory though is not essential to the workings of the linter, and needn't be distributed with every linter installation. It is good to have these things documented, but I am not convinced that a subdirectory is the right place. I'll have to look into this.

@Manuzor
Copy link
Author

Manuzor commented Apr 21, 2018

Yea it's true, the samples I provide will work if you specify the linter args directly. Made me realize the PR in its current state is kind of useless then... 😅

Given that this plugin already makes use of dub describe, I jumped to the conclusion that stuff like -J=. should work automatically.

Closing this PR.

@Manuzor Manuzor closed this Apr 21, 2018
@veelo
Copy link
Owner

veelo commented Apr 22, 2018

stuff like -J=. should work automatically.

Correct. Feel free to open a PR against readme.md if you think the documentation can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants