-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mollie): Add missing status
type
#2499
fix(mollie): Add missing status
type
#2499
Conversation
❌ Deploy Preview for effervescent-donut-4977b2 failed.
|
Not sure if the generated types have to be included, my guess is that they're formatting changes. |
Hi! Regarding the generated type files - yes they should be updated just to add this new field, but that should be a single line change. What happens if you run codegen without then formatting afterwards? |
2c00333
to
4826138
Compare
Should be resolved now :)! |
Well, the Mollie API only returns active payment methods, so this field will always return 'activated'. What is the reason for adding this field? |
It doesn't actually! It will also return ones with status |
Is that a bug in the Mollie API or SDK? We're using the mollie client
and the jsdoc for that method says:
whereas in the mollie docs it says that so what doesn't make sense to me is how a "not requested" (null) method can at the same time be "enabled". Something doesn't add up. |
Yeah, does seem to be a bug in the Mollie API. Additional context: We're loading the enabled Mollie payment methods, however, "Vouchers" show up with status |
OK, thanks for the clarifications. There's no harm adding this field even in future if Mollie fixes their probably bug and then it will just always be "activated" |
Oh wow, good find. Then yes, in this case we should just proxy the |
Description
Adds a missing
status
field to themolliePaymentMethods
query. This type was previously not typed by Mollie. It is documented however.PR on Mollie's API plugin: mollie/mollie-api-node#335
Breaking changes
None.
Checklist
📌 Always:
⚡ Most of the time: