modernize js #1468
Open
modernize js #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current JavaScript [standards](https://medium.com/@codingsam/awesome-javascript-no-more-var-working-title-999428999994) encourage us to use of let and const instead.
polarathene
approved these changes
Apr 2, 2022
nrdev88
reviewed
Jun 9, 2023
There was a problem hiding this comment.
I added a review of your let and const usage. Current state would break instantly on every browser.
By the way, encouragement of let/const is only true when using >= ES6. I don't know anything about the usage of this file or where it is used within Ventoy, but keep in mind that your (or your client's) js runtime needs to support >= ES6.
| var url = '/vtoy/json'; | ||
| var data = {}; | ||
| var func = function(data) {}; | ||
| const url = '/vtoy/json'; |
| var data = {}; | ||
| var func = function(data) {}; | ||
| const url = '/vtoy/json'; | ||
| const data = {}; |
| var func = function(data) {}; | ||
| const url = '/vtoy/json'; | ||
| const data = {}; | ||
| const func = function(data) {}; |
| msg : "提示内容", | ||
| type: 'S', | ||
| time: 3000 | ||
| }; | ||
| $.extend(ops, options); | ||
|
|
||
| var msg_class = 'alert-success'; | ||
| const msg_class = 'alert-success'; |
| @@ -242,29 +242,29 @@ window.Message = function() { | |||
| alert("未知的类型，请使用: w-警告;s-成功;e-失败;i-提示"); | |||
| return; | |||
| } | |||
| var $messageContainer = $("#fcss_message"); | |||
| const $messageContainer = $("#fcss_message"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current JavaScript standards encourage us to use of let and const instead.