Add length check on command line input #1559
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team and I were looking through the Ventoy source code using our AI-based source code anomaly detection tool, MP-CodeCheck, and found this line that, while currently functioning correctly, may benefit from a slight adjustment for the sake of maintainability: a check on the length of the input string
argv[1]
before checking its first two characters.This way, a developer who may modify this line in the future, especially if the program checks for longer string prefixes, will be more likely to be conscious of valid string checking to avoid undefined behavior.