Replace with real Intel profile Identifier

Signed-off-by: Yogesh Deshpande <[email protected]>
veraison · Feb 11, 2025 · 188755a · 188755a
1 parent 7c8464c
commit 188755a
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 11 deletions.
diff --git a/comid/measurement.go b/comid/measurement.go
@@ -441,7 +441,6 @@ func (o Mval) Valid() error {
 		o.UEID == nil &&
 		o.UUID == nil &&
 		o.IntegrityRegisters == nil &&
-
 		o.Extensions.IsEmpty() {
 		// Check for Value as well, need an API to add something
 		return fmt.Errorf("no measurement value set")

diff --git a/comid/tdx-profile/example_pce_refval_test.go b/comid/tdx-profile/example_pce_refval_test.go
@@ -14,7 +14,7 @@ import (
 
 // Example_decode_PCE_JSON decodes the TDX Provisioning Certification Enclave Measurement Extensions from the given JSON Template
 func Example_decode_PCE_JSON() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}
@@ -198,7 +198,7 @@ var (
 )
 
 func Example_decode_PCE_CBOR() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}
@@ -250,7 +250,7 @@ func Example_decode_PCE_CBOR() {
 }
 
 func Example_encode_tdx_pce_refval_with_profile() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}

diff --git a/comid/tdx-profile/example_qe_refval_test.go b/comid/tdx-profile/example_qe_refval_test.go
@@ -16,7 +16,7 @@ import (
 
 // Example_decode_QE_JSON decodes the TDX Quoting Enclave Measurement Extensions from the given JSON Template
 func Example_decode_QE_JSON() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}
@@ -266,7 +266,7 @@ var (
 )
 
 func Example_decode_QE_CBOR() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}

diff --git a/comid/tdx-profile/example_seam_refval_test.go b/comid/tdx-profile/example_seam_refval_test.go
@@ -18,7 +18,7 @@ import (
 
 // Example_decode_JSON decodes the TDX Measurement Extensions from the given JSON Template
 func Example_decode_JSON() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}
@@ -110,7 +110,7 @@ func Example_encode_tdx_seam_refval_without_profile() {
 }
 
 func Example_encode_tdx_seam_refval_with_profile() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}
@@ -244,7 +244,7 @@ func setTDXSeamMvalExtensions(val *comid.Mval) error {
 
 	teeAttr, err := NewTeeAttributes(TestTeeAttributes)
 	if err != nil {
-		fmt.Errorf("unable to get teeAttributes %w", err)
+		return fmt.Errorf("unable to get teeAttributes %w", err)
 	}
 	err = val.Extensions.Set("attributes", teeAttr)
 	if err != nil {
@@ -378,7 +378,7 @@ var (
 )
 
 func Example_decode_CBOR() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}

diff --git a/comid/tdx-profile/mval_extensions.go b/comid/tdx-profile/mval_extensions.go
@@ -39,9 +39,11 @@ type MValExtensions struct {
 // danger with that is if the your profile ID clashes with another profile,
 // which should not happen if it a registered PEN or a URL containing a domain
 // that you own.
+// Note Intel profile is "2.16.840.1.113741.1.16.1",
+// which is "joint-iso-itu-t.country.us.organization.intel.intel-comid.profile"
 
 func init() {
-	profileID, err := eat.NewProfile("http://intel.com/tdx-profile")
+	profileID, err := eat.NewProfile("2.16.840.1.113741.1.16.1")
 	if err != nil {
 		panic(err) // will not error, as the hard-coded string above is valid
 	}