Ian #20
Open
Ian #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relocate main.go, add a makefile and enable basic logging and config parsing for ratsd Signed-off-by: Ian Chin Wang <[email protected]>
Use oapi-codegen to generate server side code Signed-off-by: Ian Chin Wang <[email protected]>
Signed-off-by: Ian Chin Wang <[email protected]>
Add a script to (re-)generate all certificates necessary for ratsd core, and change the default protocol from HTTP to HTTPS Ratsd certs are signed with a cert named "rootCA.crt" in the same directory as the script (and the certs that will be generated). The script will generate a self-signed rootCA.crt if one isn't provided. Signed-off-by: Ian Chin Wang <[email protected]>
iolivergithub
requested review from
cowbon,
thomas-fossati,
deeglaze and
jraman567
as code owners
|
This could be handled within Tom's PR without creating a new one, no? |
|
Yes. But I created my own branch not to pollute Ton's
…On Wed, 15 Jan 2025, 22:37 Thomas Fossati, ***@***.***> wrote:
This could be handled within Tom's PR without creating a new one, no?
—
Reply to this email directly, view it on GitHub
<#20 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHKY2MMMYAMFVG7QEPDE7FD2K3BJPAVCNFSM6AAAAABVICBOKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTHA4DINZZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
For such a minor change, probably it's better to merge it to my remote |
my preference would be to handle it as a review comment/"suggested text" that can be handled as a commit onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a minor typo in the current response to /ratsd/chares