-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some getters to ChallengeResponseSession
, VeraisonApiEndpoint
…
#13
Add some getters to ChallengeResponseSession
, VeraisonApiEndpoint
…
#13
Conversation
a72a9f8
to
c995b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Curiosity: could you give us a bit of context for this patch?
Thanks @gbryant-arm Could you please fix the failing DCO check? |
… and `VeraisonVerificationApi` Signed-off-by: Guilhem Bryant <[email protected]>
c995b9d
to
1bbf426
Compare
Hi Thomas!
I'm rewriting bits of https://github.com/CCC-Attestation/attested-tls-poc/ to Rust, mainly the TLS client and server |
However, if you are going to use it in a Rust program, you can use the Rust API directly. That said, these changes look useful nevertheless. |
Correct. It looked like some C code was different from the underlying Rust code and paradoxically easier to use than Rust, but @paulhowardarm pointed me in the right direction and it turned out the Rust implementation had everything I needed |
… and `VeraisonVerificationApi` (veraison#13) Signed-off-by: Guilhem Bryant <[email protected]>
… and
VeraisonVerificationApi