Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some getters to ChallengeResponseSession, VeraisonApiEndpoint #13

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

gbryant-arm
Copy link
Contributor

… and VeraisonVerificationApi

@gbryant-arm gbryant-arm force-pushed the gbryant-arm/add-getters branch from a72a9f8 to c995b9d Compare November 2, 2023 13:18
Copy link

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Curiosity: could you give us a bit of context for this patch?

@thomas-fossati
Copy link
Contributor

Thanks @gbryant-arm

Could you please fix the failing DCO check?

… and `VeraisonVerificationApi`

Signed-off-by: Guilhem Bryant <[email protected]>
@gbryant-arm gbryant-arm force-pushed the gbryant-arm/add-getters branch from c995b9d to 1bbf426 Compare November 2, 2023 16:38
@gbryant-arm
Copy link
Contributor Author

Hi Thomas!

Curiosity: could you give us a bit of context for this patch?

I'm rewriting bits of https://github.com/CCC-Attestation/attested-tls-poc/ to Rust, mainly the TLS client and server

@thomas-fossati thomas-fossati merged commit e34784d into veraison:main Nov 2, 2023
4 checks passed
@thomas-fossati
Copy link
Contributor

Hi Thomas!

Curiosity: could you give us a bit of context for this patch?

I'm rewriting bits of https://github.com/CCC-Attestation/attested-tls-poc/ to Rust, mainly the TLS client and server

However, if you are going to use it in a Rust program, you can use the Rust API directly.

That said, these changes look useful nevertheless.

@gbryant-arm
Copy link
Contributor Author

However, if you are going to use it in a Rust program, you can use the Rust API directly.

Correct. It looked like some C code was different from the underlying Rust code and paradoxically easier to use than Rust, but @paulhowardarm pointed me in the right direction and it turned out the Rust implementation had everything I needed

thomas-fossati pushed a commit to thomas-fossati/rust-apiclient that referenced this pull request Oct 10, 2024
… and `VeraisonVerificationApi` (veraison#13)

Signed-off-by: Guilhem Bryant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants