Skip to content

upgrade lambda_runtime crate dependencies & add async handler fn support #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hanabi1224
Copy link

@hanabi1224 hanabi1224 commented Sep 17, 2021

This PR includes below changes, please let me know ur feedback, thanks!

  • Add async handler fn support
  • Make tokio an optional dependency behind feature runtime (default on)
  • Upgrade tokio to 1.14
  • Upgrade http to 0.2
  • Upgrade lambda_runtime to 0.4
  • Upgrade to rust 2021

The API change in this PR should keep backward compatibility. All style changes come from cargo fmt

Resolves #46 #20

@frencojobs
Copy link

Could normal and async stuff be in separate files (e.g sync.rs and async.rs), since they're pretty much distinct from what I see in the implementation?

Also, why do we need this?

# Cargo.toml
[dev-dependencies]
anyhow = "1"
tokio = "1.12"

@ngryman
Copy link
Contributor

ngryman commented Nov 12, 2021

Async should really be a first-class citizen.
Is there anything we could do to move this forward?

@hanabi1224
Copy link
Author

hanabi1224 commented Nov 13, 2021

It will be great if this PR can get reviewed soon, before it's merged and published, ppl can point the crate to my fork

# Cargo.toml
vercel_lambda = {git = "https://github.com/hanabi1224/rust", branch = "update_lambda_runtime_deps"}

@hanabi1224 hanabi1224 force-pushed the update_lambda_runtime_deps branch from 1515e29 to 0b0471c Compare November 16, 2021 11:44
@ArthurianX
Copy link

Is this abandoned ?

@ecklf
Copy link
Collaborator

ecklf commented Mar 13, 2023

Closing this in favor of https://github.com/vercel-community/rust/pull/80/files

@ecklf ecklf closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update all dependencies to their latest versions
5 participants