Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filename flag to change built filename #643

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: add filename flag to change built filename #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7578911
feat: add `filename` flag to customize filename
MaximDevoir Jan 13, 2021
6d395fd
docs: add `filename` flag
MaximDevoir Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Outputs the Node.js compact build of `input.js` into `dist/index.js`.
-q, --quiet Disable build summaries / non-error outputs
-w, --watch Start a watched build
--v8-cache Emit a build using the v8 compile cache
-f, --filename [file] Name of built file (default: index.c|js)
--license [file] Adds a file containing licensing information to the output
--stats-out [file] Emit webpack stats as json to the specified output file
--target [es2015|es2020] Select ecmascript target to use for output
Expand Down
26 changes: 18 additions & 8 deletions src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Options:
-w, --watch Start a watched build
-t, --transpile-only Use transpileOnly option with the ts-loader
--v8-cache Emit a build using the v8 compile cache
-f, --filename [file] Name of built file (default: index.c|js)
--license [file] Adds a file containing licensing information to the output
--stats-out [file] Emit webpack stats as json to the specified output file
--target What build target to use for webpack (default: es6)
Expand All @@ -57,13 +58,13 @@ else {
api = true;
}

function renderSummary(code, map, assets, ext, outDir, buildTime) {
function renderSummary(code, map, assets, filename, outDir, buildTime) {
if (outDir && !outDir.endsWith(sep)) outDir += sep;
const codeSize = Math.round(Buffer.byteLength(code, "utf8") / 1024);
const mapSize = map ? Math.round(Buffer.byteLength(map, "utf8") / 1024) : 0;
const assetSizes = Object.create(null);
let totalSize = codeSize;
let maxAssetNameLength = 8 + (map ? 4 : 0); // length of index.js(.map)?
let maxAssetNameLength = filename.length + (map ? 4 : 0); // length of filename(.map)?
for (const asset of Object.keys(assets)) {
const assetSource = assets[asset].source;
const assetSize = Math.round(
Expand All @@ -81,10 +82,10 @@ function renderSummary(code, map, assets, ext, outDir, buildTime) {

let indexRender = `${codeSize
.toString()
.padStart(sizePadding, " ")}kB ${outDir}index${ext}`;
.padStart(sizePadding, " ")}kB ${outDir}${filename}`;
let indexMapRender = map ? `${mapSize
.toString()
.padStart(sizePadding, " ")}kB ${outDir}index${ext}.map` : '';
.padStart(sizePadding, " ")}kB ${outDir}${filename}.map` : '';

let output = "",
first = true;
Expand Down Expand Up @@ -148,6 +149,8 @@ async function runCmd (argv, stdout, stderr) {
"--transpile-only": Boolean,
"-t": "--transpile-only",
"--license": String,
"--filename": String,
"-f": "--filename",
"--stats-out": String,
"--target": String
}, {
Expand Down Expand Up @@ -227,7 +230,13 @@ async function runCmd (argv, stdout, stderr) {
let startTime = Date.now();
let ps;
const buildFile = eval("require.resolve")(resolve(args._[1] || "."));
console.log('buildfile', buildFile)
const ext = buildFile.endsWith('.cjs') ? '.cjs' : '.js';
let filename = args["--filename"] || `index${ext}`;
let baseFileName = filename.replace(/\.[^/.]+$/, "");
console.log('set filename', filename)
console.log('baseFileName', baseFileName)

const ncc = require("./index.js")(
buildFile,
{
Expand All @@ -241,6 +250,7 @@ async function runCmd (argv, stdout, stderr) {
watch: args["--watch"],
v8cache: args["--v8-cache"],
transpileOnly: args["--transpile-only"],
filename: args["--filename"],
license: args["--license"],
quiet,
target: args["--target"]
Expand All @@ -265,8 +275,8 @@ async function runCmd (argv, stdout, stderr) {
new Promise((resolve, reject) => unlink(file, err => err ? reject(err) : resolve())
))
);
writeFileSync(`${outDir}/index${ext}`, code, { mode: code.match(shebangRegEx) ? 0o777 : 0o666 });
if (map) writeFileSync(`${outDir}/index${ext}.map`, map);
writeFileSync(`${outDir}/${baseFileName}${ext}`, code, { mode: code.match(shebangRegEx) ? 0o777 : 0o666 });
if (map) writeFileSync(`${outDir}/${baseFileName}${ext}.map`, map);

for (const asset of Object.keys(assets)) {
const assetPath = outDir + "/" + asset;
Expand All @@ -285,7 +295,7 @@ async function runCmd (argv, stdout, stderr) {
code,
map,
assets,
ext,
filename,
run ? "" : relative(process.cwd(), outDir),
Date.now() - startTime,
) + '\n'
Expand All @@ -312,7 +322,7 @@ async function runCmd (argv, stdout, stderr) {
} while (nodeModulesDir = resolve(nodeModulesDir, "../../node_modules"));
if (nodeModulesDir)
symlinkSync(nodeModulesDir, outDir + "/node_modules", "junction");
ps = require("child_process").fork(`${outDir}/index${ext}`, {
ps = require("child_process").fork(`${outDir}/${baseFileName}${ext}`, {
stdio: api ? 'pipe' : 'inherit'
});
if (api) {
Expand Down