Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated with-react-foundation example to utilize the App router. #73243

Open
wants to merge 6 commits into
base: canary
Choose a base branch
from
Open

updated with-react-foundation example to utilize the App router. #73243

wants to merge 6 commits into from
+52 −24

Conversation

PapatMayuri
Copy link
Contributor

@PapatMayuri PapatMayuri commented Nov 27, 2024 •
edited
Loading

This PR updates the with-react-foundation example for using the App Router.
Here are the changes that have been made:

  • I renamed the pages folder and moved it to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Moved component folder into app folder.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue/PR related to examples label Nov 27, 2024
@ijjk
Copy link
Member

ijjk commented Nov 27, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: ac5b6ab

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review November 27, 2024 06:59
@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +29 372 MB joeworkman

🚮 Removed packages: npm/[email protected]

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PapatMayuri @ijjk