[17.0][MIG] web_company_color: Migration to 17.0 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (9 of 9 strings) Translation: web-12.0/web-12.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings) Translation: web-12.0/web-12.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/it/
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/nl/
We need to disable the company unlinking test, as if not, when tested in integrated environments, it fails as there are records linked to the company, like the warehouse when `stock` module is installed.
Currently translated at 100.0% (12 of 12 strings) Translation: web-14.0/web-14.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/de/
Currently translated at 8.3% (1 of 12 strings) Translation: web-14.0/web-14.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/ca/
Currently translated at 100.0% (10 of 10 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/nl/
Currently translated at 100.0% (10 of 10 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/es/
Before it didn't work if just a color was set because it couldn't find "color_navbar_bg_hover". Moreover, in odoo enterprise the navbar background color only worked for the main app menu, now it works for both main app menu and the navbar of the apps.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/
Currently translated at 100.0% (16 of 16 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/fr/
Currently translated at 100.0% (16 of 16 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/es/
Currently translated at 100.0% (16 of 16 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/it/
Currently translated at 100.0% (16 of 16 strings) Translation: web-16.0/web-16.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_company_color/pt/
…ing the assetbundle
When trying to charge the assetbundle the theme-color("primary") function
is not found what causes problems when trying to set the default values.
With this changes the default value is the value set on https://github.com/odoo/odoo/blob/ad9f8fae717aae4cad5b3715c1f73ee906b64f8d/addons/web/static/src/scss/primary_variables.scss#L55
this change avoid the problems and the module works fine.
Addapted too the class for required fields.
maciej-wichowski
force-pushed
the
17.0-versada
branch
from
5cc45f2
to
6dbc334
Compare
|
Please check only 1d483d7 commit. |
psugne
requested review from
maciej-wichowski
and removed request for
oerp-odoo
|
Switching reviewers as @oerp-odoo is off today, I'm a bit on an urgent side and you @maciej-wichowski are already related with web :) |
maciej-wichowski
approved these changes
Oct 17, 2024
|
@maciej-wichowski is is not a public repo, it's 17.0-versada branch which will be used only inside :) |
Yes, I know, but it is publicly visible. And we don't want to show our internal services to everyone :) It's not even my invention, Andrius pointed it to me some time ago. So please remove link to hive from your first comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiration gotten from OCA commit