Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @vikignt !
The Textfield component was kind of buggy, at least in our workflow.
error
prop was present, it would show no matter what.error
prop was present, even when the required field was set and the input was filled, the error would still persist.With this PR, the following things happen, hopefully setting some things straight and making it more a component than a display.
validator
callback to check the value of the component against, and set theinvalid
flag on it when false is returned.error
is not displayed, unless the component value is actually invalid (invalid is - for example - an empty string when therequired
is set, or a value that fails thevalidator
callback.)We also believe that the default value for
messagePersist
should change totrue
- since we always - always - have to fill this up. I would like to hear what other users think on this.