New Tabs Component added. #37
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Tabs page to Examples and made needed changes for that.
ellemenno
added a commit
to ellemenno/vbstats
that referenced
this pull request
Mar 7, 2021
ellemenno
added a commit
to ellemenno/vbstats
that referenced
this pull request
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello vikignt,
First of all, thank you for creating this minimal sized MUI project.
Smaller size is also what drew me to this.
I've added new Tabs component to svelte-mui.
It contains two components: Tabs (swipe enabled) and Tab component.
Added a new page to Examples as well to show how it is used.
Understandably, you want to keep this minimal, so if you see this viable, I think it will be a good addition.
After adding Tabs, I did check the build bundle size of the whole project including example.
bundle.js added 19KBs and bundle.css added 2KBs. This is including the example pages.
Before adding Tabs: js: 303kb. css: 35kb
After adding Tabs: js: 322kb. css 37kb
Thanks again.