Skip to content
This repository has been archived by the owner on Jan 2, 2020. It is now read-only.

Add abbreviations to create unicode ops #9

Closed
wants to merge 2 commits into from
Closed

Add abbreviations to create unicode ops #9

wants to merge 2 commits into from

Conversation

Tyil
Copy link
Contributor

@Tyil Tyil commented Oct 10, 2017

Fixes #8

@Tyil
Copy link
Contributor Author

Tyil commented Oct 24, 2017

Two weeks with no response, I'm forking this into @scriptkitties and will apply patches there. If this project stays dead and my patches work well enough, I'll update the link to the vim-perl6 plugin on docs.perl6 as well.

@petdance
Copy link
Contributor

I'd like to suggest that "we haven't looked at it in 15 days" is not the same thing as "dead".

@hoelzro
Copy link
Member

hoelzro commented Oct 24, 2017

@Tyil Sorry for the delay - I tend to work on OSS projects on a six-week cycle, and I'm playing catch-up right now. This project has stagnated some, though - would you be up for helping to maintain it?

@Tyil
Copy link
Contributor Author

Tyil commented Oct 25, 2017

@petdance Some PR has taken literal months before being looked at, that doesn't say the project is very much alive either.

@hoelzro I am up to help to maintain it, I'd just maintain it under a different namespace anyway.

@hoelzro
Copy link
Member

hoelzro commented Oct 25, 2017

@Tyil so you would maintain it under a different account? (eg. @scriptkitties)?

@Tyil
Copy link
Contributor Author

Tyil commented Oct 25, 2017

I don't mind where it's being maintained, so long as I can add code easily and get feedback in a reasonable timespan. I'm currently also working on a templates branch, which has gotten some feedback already.

@hoelzro
Copy link
Member

hoelzro commented Oct 26, 2017

Well, we could always give you push access to this repo =) My opinion regarding the purpose of this repo is that it's syntax, ftplugin, and indent only - I think things like templates would be better suited as a separate plugin. That way people can choose which template plugin they want to use and not have it conflict with vim-perl6!

@Tyil
Copy link
Contributor Author

Tyil commented Oct 26, 2017

That sounds valid. Not everyone wants templates, though both features (templates and unicode abbreviations) are disabled by default already as well, since I don't know if they work correctly for everyone in every circumstance.

If I were to get push access here I'd gladly take care of PRs, review them as needed and merge them if they fix something. I'd gladly assist in a collaborated effort on this repo, as I think it's better to work together to get the best result possible.

@hoelzro
Copy link
Member

hoelzro commented Oct 27, 2017

@Tyil This looks good - would you mind putting the iabbrev statements in an if block, as suggested in #8?

Another thing to consider with the templates is if Bram will want such a facility in upstream Vim - part of our responsibility is to push updated runtime files to Vim itself.

@Tyil
Copy link
Contributor Author

Tyil commented Oct 28, 2017

It already has that in my fork, but it seems Github can't deal with my fork now being based off of scriptkitties/vim-perl6, which is based off of this repository. It says unknown repository at the PR as well, and I can't seem to update that.

@Tyil
Copy link
Contributor Author

Tyil commented Oct 28, 2017

I made a new PR to rectify this, and to show all commits on the branch correctly: #10

@Tyil Tyil closed this Oct 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants