Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ReadableResourceStream #10413

Closed
wants to merge 1 commit into from
Closed

Switch to ReadableResourceStream #10413

wants to merge 1 commit into from

Conversation

hexmode
Copy link
Contributor

@hexmode hexmode commented Nov 26, 2023

Fixes #10411

@danog
Copy link
Collaborator

danog commented Nov 26, 2023

ReadableResourceStream is an amp v3 class, 5.x is still using amp v2, so the existing code is correct.
Psalm v6 will use amp v3, and migration was already done there.

@danog danog closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psalm lsp implementation uses Amp\ByteStream\ResourceInputStream
2 participants