Merge pull request #3 from dwickstrom/fix-url-generator

Fix url generator
vinaykevadia · Dec 18, 2014 · ce964ce · ce964ce
2 parents bb28c40 + 6a2acae
commit ce964ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/spec/SeoMoz/Generator/RequestUrlSpec.php b/spec/SeoMoz/Generator/RequestUrlSpec.php
@@ -23,7 +23,7 @@ function it_generates_a_request_url()
     {
         $it = $this->generate('testa.se');
         $it->shouldBeString();
-        $it->shouldStartWith('http://lsapi.seomoz.com/');
-        $it->shouldEndWith('3D');
+        $it->shouldStartWith('http://lsapi.seomoz.com/linkscape/url-metrics/testa.se');
+        $it->shouldEndWith('%3D');
     }
 }
diff --git a/src/SeoMoz/Generator/RequestUrl.php b/src/SeoMoz/Generator/RequestUrl.php
@@ -51,17 +51,10 @@ public function generate($domainName)
      */
     private function buildUrl($domainName, $cols, $expires, $urlSafeSignature)
     {
-        $parameters = [
-            "Cols" => $cols,
-            "AccessID" => $this->accessId,
-            "Expires" => $expires,
-            "Signature" => $urlSafeSignature
-        ];
-
         $parts = [
             'http://lsapi.seomoz.com/linkscape/url-metrics/',
             urlencode($domainName),
-            http_build_query($parameters)
+            "?Cols=".$cols."&AccessID=".$this->accessId."&Expires=".$expires."&Signature=".$urlSafeSignature
         ];
 
         return implode("", $parts);