Merge pull request #165 from ztn0/fix-pickfile-safari

fix: trigger onchange event Safari
vinceglb · Dec 11, 2024 · 46d51bd · 46d51bd
2 parents 12c167d + 4061fac
commit 46d51bd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/filekit-core/src/jsMain/kotlin/io/github/vinceglb/filekit/core/FileKit.js.kt b/filekit-core/src/jsMain/kotlin/io/github/vinceglb/filekit/core/FileKit.js.kt
@@ -25,6 +25,10 @@ public actual object FileKit {
         suspendCoroutine { continuation ->
             // Create input element
             val input = document.createElement("input") as HTMLInputElement
+            // Visually hide the element
+            input.style.display = "none"
+
+            document.body?.appendChild(input)
 
             // Configure the input element
             input.apply {
@@ -60,11 +64,14 @@ public actual object FileKit {
                     continuation.resume(mode.parseResult(result))
                 } catch (e: Throwable) {
                     continuation.resumeWithException(e)
+                } finally {
+                    document.body?.removeChild(input)
                 }
             }
 
             input.oncancel = {
                 continuation.resume(null)
+                document.body?.removeChild(input)
             }
 
             // Trigger the file picker

diff --git a/filekit-core/src/wasmJsMain/kotlin/io/github/vinceglb/filekit/core/FileKit.wasmJs.kt b/filekit-core/src/wasmJsMain/kotlin/io/github/vinceglb/filekit/core/FileKit.wasmJs.kt
@@ -25,6 +25,8 @@ public actual object FileKit {
         suspendCoroutine { continuation ->
             // Create input element
             val input = document.createElement("input") as HTMLInputElement
+            // Visually hide the element
+            input.style.display = "none"
 
             // Configure the input element
             input.apply {
@@ -60,11 +62,14 @@ public actual object FileKit {
                     continuation.resume(mode.parseResult(result))
                 } catch (e: Throwable) {
                     continuation.resumeWithException(e)
+                } finally {
+                    document.body?.removeChild(input)
                 }
             }
 
             input.oncancel = {
                 continuation.resume(null)
+                document.body?.removeChild(input)
             }
 
             // Trigger the file picker