-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failed to symlink overlay files if it already exists #322
Conversation
Please take this to the upstream library github.com/otiai10/copy . |
Oh ok |
@apprehensions Do you want me to close this pr or merge this while i move this to upstream lib? |
Discuss with library maintainer to determine if this patch belongs there or here. |
@apprehensions Found out it wasn't upstream lib issue we need to check if file already exists first. (otiai10/copy#132) |
Sorry for getting to this PR late, but does the solution have to be this complicated? |
If possible, it would be greatly appreciate to test this, just to enforce and proof the new behavior. A guide on how to make Go tests can be found here. |
I have added test cases, I am not sure if this is what you want. |
Please fix conflicts for merge. Thanks for your work as well. Do try to use |
Done! |
@apprehensions Maybe you can close this now since otiai10/copy#145 has been merged. |
I have asked the pull request and the issue author to verify if the issue has been solved. If it is for you having faced this issue, please let me know. |
I have checked myself and the PR fixes it. |
Thank you for your work @starzation |
Fixed #321