Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/meta tags #139

Merged

Conversation

anmolkaur18
Copy link

@anmolkaur18 anmolkaur18 commented Mar 7, 2020

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@auto-assign auto-assign bot requested a review from vinitshahdeo March 7, 2020 17:17
@vinitshahdeo vinitshahdeo changed the base branch from master to feature/frontend March 7, 2020 18:28
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @anmolkaur18 👏 👏

@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels Mar 7, 2020
@vinitshahdeo vinitshahdeo merged commit 9a58542 into vinitshahdeo:feature/frontend Mar 9, 2020
@welcome
Copy link

welcome bot commented Mar 9, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@anmolkaur18 anmolkaur18 mentioned this pull request Apr 11, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants