Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme Typo Fixed #252

Closed
wants to merge 2 commits into from
Closed

Readme Typo Fixed #252

wants to merge 2 commits into from

Conversation

ayan-biswas0412
Copy link

@ayan-biswas0412 ayan-biswas0412 commented May 9, 2020 •
edited
Loading

Description

I have fixed the typo of the Readme as mentioned in #245

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@auto-assign auto-assign bot requested a review from vinitshahdeo May 9, 2020 09:27
@ayan-biswas0412 ayan-biswas0412 mentioned this pull request May 9, 2020
Closed
8 tasks
@ayan-biswas0412
Copy link
Author

@PragatiVerma18 @vinitshahdeo against the issue #245 i have opened this PR

This was referenced May 9, 2020
Open
Open
@ayan-biswas0412 ayan-biswas0412 changed the title Readme Typo Fixed #245 Readme Typo Fixed May 9, 2020
PragatiVerma18
PragatiVerma18 suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not make unnecessary changes like just adding a newline. We don't accept such changes.

PragatiVerma18
PragatiVerma18 suggested changes May 15, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow proper markdown and remove the additional '+' before the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragatiVerma18 PragatiVerma18 PragatiVerma18 requested changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayan-biswas0412 @PragatiVerma18 @vinitshahdeo