Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Removing typos in FAQ section #258

Merged
merged 43 commits into from
May 31, 2020
Merged

FIX: Removing typos in FAQ section #258

merged 43 commits into from
May 31, 2020

Conversation

tannerdolby
Copy link

@tannerdolby tannerdolby commented May 15, 2020

Description

I removed grammatical errors within the FAQ section of README.md and fixed any spacing issue between sentences. Now the FAQ section should not contain any typos.

Fixes #245
Removed all typos from FAQ within README.md.

Type of change

Markup change (specifically fixing grammar and any spacing issues)

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented May 15, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@tannerdolby
Copy link
Author

@vinitshahdeo @PragatiVerma18 Let me know if there is anything else I need to fix or improve regarding this issue. Thank you both for allowing me to get some experience with creating a pull request!

vinitshahdeo and others added 5 commits May 20, 2020 18:42
- Edit the section 'Getting started' with git workflow instructions
- Updated instructions to synch up local and remote repo before pushing your changes.
- Check for any latest updates on the Upstream and merge them with your work before pushing
- Follow the above steps before creting a PR

Edit git workflow-synch with remote + add workflow flowchart
@PragatiVerma18
Copy link
Contributor

@tannercd please resolve the merge conflicts by adding a commit. Please do it before 31st May to make it count under GSSoC.

@PragatiVerma18 PragatiVerma18 added the gssoc20 Welcome to GirlScript Summer of Code 2020 label May 30, 2020
@tannerdolby
Copy link
Author

@PragatiVerma18 The commit cde33a3 resolved the merge conflicts in README.md. Let me know if I need to do anything else to complete this PR before the deadline tomorrow (31st May). Thank you for all your help!

@tannerdolby
Copy link
Author

tannerdolby commented May 30, 2020 via email

@PragatiVerma18 PragatiVerma18 merged commit c78e615 into vinitshahdeo:feature/documentation May 31, 2020
@welcome
Copy link

welcome bot commented May 31, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@PragatiVerma18 PragatiVerma18 added the easy Easy issue label May 31, 2020
@tannerdolby tannerdolby deleted the pr/faqTypo branch May 31, 2020 18:57
@tannerdolby
Copy link
Author

@PragatiVerma18 @vinitshahdeo thank you both for allowing me to contribute. Be well!

@tannerdolby tannerdolby mentioned this pull request Oct 1, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants