Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/backend node - Implemented auto generated docs with Swagger #332

Merged
merged 7 commits into from
Sep 5, 2020
Merged

Feature/backend node - Implemented auto generated docs with Swagger #332

merged 7 commits into from
Sep 5, 2020

Conversation

anandhakrishnanaji
Copy link

@anandhakrishnanaji anandhakrishnanaji commented Aug 21, 2020 •
edited
Loading

Description

I created documentation for readingRoutes.js, Reading.js and auth.js. Created a new file called swagger.js in routes folder for documentation purpose.

Dependancies:

[email protected]
[email protected]

Fixes #323

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: @vinitshahdeo

@welcome
Copy link

welcome bot commented Aug 21, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@anandhakrishnanaji anandhakrishnanaji changed the title Feature/backend node Feature/backend node - Implemented auto generated docs with Swagger Aug 26, 2020
@anandhakrishnanaji
Copy link
Author

Issue #323 @ArpitKotecha

@anandhakrishnanaji
Copy link
Author

@vinitshahdeo

ArpitKotecha
ArpitKotecha suggested changes Sep 3, 2020
View reviewed changes
api/routes/auth.js Outdated Show resolved Hide resolved
api/routes/auth.js Outdated Show resolved Hide resolved
api/routes/readingRoutes.js Show resolved Hide resolved
api/routes/readingRoutes.js Show resolved Hide resolved
api/routes/tankroutes.js Show resolved Hide resolved
@anandhakrishnanaji
Copy link
Author

All changes are made, am I supposed to do anything more @ArpitKotecha?

@ArpitKotecha
Copy link
Contributor

LGTM

@ArpitKotecha ArpitKotecha merged commit 2f13933 into vinitshahdeo:feature/backend-node Sep 5, 2020
@welcome
Copy link

welcome bot commented Sep 5, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@anandhakrishnanaji anandhakrishnanaji deleted the feature/backend-node branch September 5, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArpitKotecha ArpitKotecha ArpitKotecha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandhakrishnanaji @ArpitKotecha