Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #343

Closed
wants to merge 70 commits into from
Closed

Conversation

shibam17
Copy link

@shibam17 shibam17 commented Sep 30, 2020

Solved issue #245

Description

Solved the typo errors.

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@nandikajain
Copy link
Contributor

@vinitshahdeo multiple PR's are made for the same typo.

Copy link
Contributor

@nandikajain nandikajain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send PR to feature/documentation

@shibam17
Copy link
Author

@nandikajain I did not get you. What?

@nandikajain
Copy link
Contributor

@soulhunter10737 Currently, you have sent the PR to master. Please change the branch and send it to feauture/documentation

@shibam17 shibam17 changed the base branch from master to feature/documentation October 12, 2020 19:46
@shibam17
Copy link
Author

Done @nandikajain

@nandikajain
Copy link
Contributor

nandikajain commented Oct 12, 2020

https://github.com/vinitshahdeo/Water-Monitoring-System/pull/343/conflicts
resolve these conflicts as well

GitHub
GitHub is where people build software. More than 50 million people use GitHub to discover, fork, and contribute to over 100 million projects.

@shibam17
Copy link
Author

Thank you @nandikajain just a follow up thing, 😓 can you label it as hacktoberfest thing

@nandikajain
Copy link
Contributor

No changes required in the Readme, closing PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants