feat: buildless ecosystem ci #18525

Aslemammad · 2024-10-30T21:26:16Z

By using the --commit option in vite-ecosystem-ci, we can leverage the already built versions of vite in pkg.pr.new!

Here, after sending the ecosystem comment, we'll check if there's an already built version, if not, we'll try triggering a build. The 🚀 reaction is a sign that the build is happening and we should wait until it's done.

After that, the normal process continues.

Aslemammad · 2024-10-30T21:27:11Z

/ecosystem-ci run

pkg-pr-new · 2024-11-01T13:31:07Z

Open in Stackblitz

pnpm add https://pkg.pr.new/vitejs/vite@18525

commit: c97f0eb

Aslemammad · 2024-11-05T08:15:41Z

/ecosystem-ci run

Aslemammad · 2024-11-05T08:54:37Z

.github/workflows/ecosystem-ci-trigger.yml

+          script: |
+            const prData = ${{ steps.get-pr-data.outputs.result }}
+            const url = `https://pkg.pr.new/vite@${prData.commit}`
+            const response = await fetch(url)


We do not yet implement the HEAD for pkg.pr.new! So here instead of consuming the request body and waiting for it, we just check the status and then the step would be done.

So if it was fetching, it'd be aborted I think.

cc @dominikg

if you await fetch(), the full file has been downloaded already, its just not been parsed yet. of course if pkg.pr.new does not implement head we have to go with full, but should be considered as an optimization. or do you implement the endpoints about package information that the public registry has?

if you await fetch(), the full file has been downloaded already

I did not know that, does not that defeat the purpose of streams (e.g. .body)?

As far as I know the await on .body would wait until finishing the fetch and meanwhile give us the result buffer by buffer while fetching.

but should be considered as an optimization

💯

hmm, maybe need to get more coffee and you are right.

Haha, thanks, let me get my own coffee too now 😅

We do not yet implement the HEAD for pkg.pr.new!

Any plan to support it? It sounds interesting.

Any plan to support it? It sounds interesting.

I'll create an issue for it then!

dominikg · 2024-11-05T09:42:44Z

/ecosystem-ci run

Aslemammad · 2024-11-05T09:47:10Z

As far as I know this tests the previous version of vite-ecosystem-ci rather than the new one. Which makes it requires a merge.

…

On Tue, 5 Nov 2024, 13:43 vite-ecosystem-ci[bot], ***@***.***> wrote: ⏳ Triggered ecosystem CI: Open <https://github.com//vitejs/vite-ecosystem-ci/actions/runs/11681487209> — Reply to this email directly, view it on GitHub <#18525 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJBMICDQVZRRLA6YQFS6JPLZ7CHMDAVCNFSM6AAAAABQ5A7JXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJWGY4TMNBWGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

vite-ecosystem-ci · 2024-11-05T09:54:01Z

📝 Ran ecosystem CI on 5406307: Open

suite	result	latest scheduled
astro	❌ failure	❌ failure
histoire	❌ failure	❌ failure
redwoodjs	❌ failure	❌ failure
remix	❌ failure	❌ failure
sveltekit	❌ failure	❌ failure
unocss	❌ failure	❌ failure
vike	❌ failure	❌ failure
vite-environment-examples	❌ failure	✅ success
vite-plugin-react	✅ success	❌ failure
vite-plugin-svelte	✅ success	❌ failure
vite-plugin-vue	❌ failure	❌ failure
vitest	❌ failure	❌ failure

✅ analogjs, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, vite-plugin-pwa, vite-plugin-react-swc, vite-setup-catalogue, vitepress, vuepress

.github/workflows/ecosystem-ci-trigger.yml

sapphi-red

The code looks good to me 👍

.github/workflows/ecosystem-ci-trigger.yml

sapphi-red · 2024-11-26T04:12:15Z

.github/workflows/ecosystem-ci-trigger.yml

+      - name: Checkout
+        uses: actions/checkout@v4
        with:
-          app_id: ${{ secrets.ECOSYSTEM_CI_GITHUB_APP_ID }}
-          installation_retrieval_payload: "${{ github.repository_owner }}/vite-ecosystem-ci"
-          private_key: ${{ secrets.ECOSYSTEM_CI_GITHUB_APP_PRIVATE_KEY }}
-      - uses: actions/github-script@v7
+          fetch-depth: 0
+
+      - name: Check Commit Hash Ambiguity
+        id: check_ambiguity
+        run: |
+          HEAD_SHA=${{ steps.get-pr-data.outputs.head_sha }}
+          COMMIT_SHORT=${HEAD_SHA:0:7}
+
+          if git show "$COMMIT_SHORT"; then
+            echo "COLLISION=false" >> $GITHUB_ENV
+          else
+            echo "COLLISION=true" >> $GITHUB_ENV
+          fi


Let me confirm when these steps can be removed. Is the following understanding right?

It cannot be removed now because even if we passed the full hash to pr.pkg.new, pr.pkg.new will try to match with 7char prefix if it didn't match with the full hash.
It can be removed after all the 7char is purged. How long does it take for that? If the date is known, could we have a comment that says "we can remove this in ..."?

will try to match with 7char prefix

exactly, any release made before yesterday, will match the 7char version of commits (yesterday's release fixes that completely but only gets applied after the new commits)

if we do not use any of the releases made before for a month, it'd get remove! but if we keep using it, the timeline would be expanded to at most 6 months and at that time, it'd be force deleted.

I see. Then, would you add a comment telling that this part can be removed on May 26, 2025?

Co-authored-by: 翠 / green <[email protected]>

gerick23 approved these changes Nov 4, 2024

View reviewed changes

Aslemammad commented Nov 5, 2024

View reviewed changes

Aslemammad marked this pull request as ready for review November 5, 2024 09:25

Aslemammad mentioned this pull request Nov 5, 2024

feat: pkg.pr.new vitejs/vite-ecosystem-ci#313

Merged

sapphi-red reviewed Nov 6, 2024

View reviewed changes

Aslemammad mentioned this pull request Nov 6, 2024

HEAD method stackblitz-labs/pkg.pr.new#273

Open

Aslemammad requested a review from sapphi-red November 6, 2024 06:04

sapphi-red previously approved these changes Nov 6, 2024

View reviewed changes

Aslemammad dismissed sapphi-red’s stale review via 9c747f1 November 9, 2024 12:47

Aslemammad requested review from dominikg and sapphi-red November 9, 2024 14:46

gerick23 approved these changes Nov 12, 2024

View reviewed changes

Aslemammad mentioned this pull request Nov 22, 2024

chore: full sha support stackblitz-labs/pkg.pr.new#287

Merged

sapphi-red reviewed Nov 26, 2024

View reviewed changes

Aslemammad force-pushed the feat/buildless-ecosystem-ci branch from 6c13980 to f3170e2 Compare November 26, 2024 14:50

Aslemammad and others added 9 commits November 26, 2024 18:24

init

b3cdb39

debug

f6a0bc7

debug

8098da8

debug

88bc6ec

debug

a5055fe

debug

5b26c08

debug

86b1e80

debug

998fccc

trigger ci

3620493

Aslemammad and others added 28 commits November 26, 2024 18:24

separation

1bee76b

back to basics

5c70ae1

finalize

0e156d6

better way to remove reactions

c0093cd

revert preview-release.yml

4de80ca

Update .github/workflows/ecosystem-ci-trigger.yml

e03be0e

Co-authored-by: 翠 / green <[email protected]>

Update .github/workflows/ecosystem-ci-trigger.yml

c76264c

Co-authored-by: 翠 / green <[email protected]>

Update .github/workflows/ecosystem-ci-trigger.yml

67878e0

Co-authored-by: 翠 / green <[email protected]>

Update .github/workflows/ecosystem-ci-trigger.yml

0eba61a

Co-authored-by: 翠 / green <[email protected]>

Update .github/workflows/ecosystem-ci-trigger.yml

7e13fa0

Co-authored-by: 翠 / green <[email protected]>

Update .github/workflows/ecosystem-ci-trigger.yml

43a1668

Co-authored-by: 翠 / green <[email protected]>

move permissions check to the top

2dabbab

debug git show

9841567

debug git show

03108e3

debug git show

9f8ed06

debug git show

67cb48e

debug git show

d76f695

debug git show

9a08d4a

debug git show

926392e

debug git show

0206c65

debug git show

f547431

debug git show

75afd3b

debug git show

5cb7224

debug git show

53fe902

find collisions properly

a1dbe40

remove triage diff

ad35943

a comment to note removing the hash ambiguity check

724fc9e

format

d6961c2

Aslemammad force-pushed the feat/buildless-ecosystem-ci branch from f3170e2 to d6961c2 Compare November 26, 2024 14:54

Aslemammad requested a review from sapphi-red November 26, 2024 15:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: buildless ecosystem ci #18525

feat: buildless ecosystem ci #18525

Aslemammad commented Oct 30, 2024

Aslemammad commented Oct 30, 2024

pkg-pr-new bot commented Nov 1, 2024 •

edited

Loading

Aslemammad commented Nov 5, 2024

Aslemammad Nov 5, 2024 •

edited

Loading

Aslemammad Nov 5, 2024

dominikg Nov 5, 2024 •

edited

Loading

Aslemammad Nov 5, 2024

dominikg Nov 5, 2024

Aslemammad Nov 5, 2024

dai-shi Nov 5, 2024

Aslemammad Nov 6, 2024

dominikg commented Nov 5, 2024

Aslemammad commented Nov 5, 2024 via email

vite-ecosystem-ci bot commented Nov 5, 2024

sapphi-red left a comment

sapphi-red Nov 26, 2024

Aslemammad Nov 26, 2024

sapphi-red Nov 26, 2024

Aslemammad Nov 26, 2024

feat: buildless ecosystem ci #18525

Are you sure you want to change the base?

feat: buildless ecosystem ci #18525

Conversation

Aslemammad commented Oct 30, 2024

Aslemammad commented Oct 30, 2024

pkg-pr-new bot commented Nov 1, 2024 • edited Loading

Aslemammad commented Nov 5, 2024

Aslemammad Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominikg Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominikg commented Nov 5, 2024

Aslemammad commented Nov 5, 2024 via email

vite-ecosystem-ci bot commented Nov 5, 2024

sapphi-red left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkg-pr-new bot commented Nov 1, 2024 •

edited

Loading

Aslemammad Nov 5, 2024 •

edited

Loading

dominikg Nov 5, 2024 •

edited

Loading