Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pnpm to ignoreDeps #19399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

btea
Copy link
Collaborator

@btea btea commented Feb 11, 2025

Description

I think pnpm should be upgraded manually. For example, pnpm10 has made some changes to the default behavior, and some other configurations need to be added to keep it consistent with the previous default behavior.
https://github.com/pnpm/pnpm/releases/tag/v10.0.0

@patak-dev patak-dev added the p1-chore Doesn't change code behavior (priority) label Feb 11, 2025
@sapphi-red
Copy link
Member

I think the current config is fine. There's no problem with automatically upgrading minor / patch versions of pnpm. We need to apply some changes sometimes for major bumps, but a separate PR would be created by renovate in that case.

@btea
Copy link
Collaborator Author

btea commented Feb 12, 2025

Yeah, I noticed that renovate created a separate PR #19393 to update the pnpm major version. However, due to breaking changes in pnpm 10 for script execution, the test case failed.

At this point, someone needs to add additional configuration and modify the content of the PR. I think this is not as clear and accurate as someone manually updating and creating a PR.

However, it is OK to keep it as it is. I see that other patch and minor version updates also have a history of manual modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants