Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(css): move environment destructuring after condition check #19492

Merged
merged 1 commit into from
Feb 27, 2025
Merged

chore(css): move environment destructuring after condition check #19492

merged 1 commit into from
Feb 27, 2025

Conversation

OnlyWick
Copy link
Contributor

@OnlyWick OnlyWick commented Feb 22, 2025 •
edited
Loading

The function may return early, so there's no need to read the environment first.

@benmccann benmccann mentioned this pull request Feb 25, 2025
Merged
benmccann
benmccann approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine, but you could probably bundle some of these PRs up into one. Not sure that this and #19491 need to be separate

@bluwy bluwy merged commit c9eda23 into vitejs:main Feb 27, 2025
16 checks passed
@OnlyWick OnlyWick deleted the 2025-02-22 branch March 1, 2025 06:56
@OnlyWick
Copy link
Contributor Author

OnlyWick commented Mar 1, 2025

@benmccann SORRY for replying so late. I think it's necessary to separate them. Although they are both chores, their functions are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnlyWick @benmccann @bluwy