-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a path to script folder for require
to work properly.
#264
base: master
Are you sure you want to change the base?
Conversation
Don't link an issue if you're using a checklist. I wish GitHub was that sophisticated and could allow you to check off tasks using pull requests. |
dunno how that is a problem since you can link several issues but okay i guess..? |
Because if you close the issue then it's assumed you've completed the entire check list (which I don't think is the case here). You can only link issues, not the tasks contained within them. |
Uuuhhhh what. K whatever that just makes no sense to me. |
It doesn't, and again, I wish GitHub had this as a feature, but unfortunately we don't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhhhhhh. There's some good changes, but some others seem pretty sketchy, I'd like an explanation as to why some of those changes were made.
#include "SSVOpenHexagon/Components/CWall.hpp" | ||
#include "SSVOpenHexagon/Components/CCustomWallHandle.hpp" | ||
#include "SSVOpenHexagon/Components/CCustomWall.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this? There are custom wall functions defined here that need these headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are not even used in the include.
addLuaFn("u_getAttemptRandomSeed", // | ||
[this] { return rng.seed(); }) | ||
.doc( | ||
"Obtain the current random seed, automatically generated at the " | ||
"beginning of the level. `math.randomseed` is automatically " | ||
"initialized with the result of this function at the beginning of " | ||
"a level."); | ||
[this]{ return rng.seed(); }) | ||
.doc( | ||
"Obtain the current random seed, automatically generated at the " | ||
"beginning of the level. `math.randomseed` is automatically " | ||
"initialized with the result of this function at the beginning of " | ||
"a level."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to stick to the .clang-format
that Vee has defined for us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you go away with it when the thing is god damn raw?
try | ||
{ | ||
try{ | ||
lua.executeCode("math.randomseed(u_getAttemptRandomSeed())"); | ||
} | ||
catch(...) | ||
{ | ||
catch(...){ | ||
ssvu::lo("HexagonGame::initLua") | ||
<< "Failure to initialize Lua random generator seed\n"; | ||
<< "Failure to initialize Lua random generator seed\n"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing applies here.
Still in WIP in some way, will try to figure out a better way to do it.
Meanwhile, you can suggest your ideas for what method would fit this better.