Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D perspective drawing mode #316

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

IvoryDuke
Copy link
Contributor

@IvoryDuke IvoryDuke commented Jan 8, 2021

Added a second 3D mode that more convincingly gives the illusion of a 3D environment.
To use it the level .json must set the key "3DMode" to true, and the menu 3D setting must be set to true.

Video demo: https://youtu.be/9H0KNBS1h4U

@IvoryDuke IvoryDuke changed the title 3D rendering mode 3D perspective rendering mode Jan 8, 2021
@IvoryDuke IvoryDuke changed the title 3D perspective rendering mode 3D perspective drawing mode Jan 8, 2021
@IvoryDuke IvoryDuke force-pushed the 3D-rendering branch 3 times, most recently from 0e409d1 to 6816e62 Compare January 11, 2021 00:53
@vittorioromeo
Copy link
Owner

Very interesting! Have you considered making this a per-level setting rather than a global one? In other words:

  • We would still have a boolean global setting to enable or disable 3D effects altogether
  • Each level would choose whether to be 2D, 3D (old), and 3D (new)

I think that might be a better choice so that level creators can have the most freedom

@IvoryDuke
Copy link
Contributor Author

I have actually thought about that, especially because some levels look objectively bad in the "new" 3D mode.
I have to iron out one last detail of the drawing process and then I will implement the level variable.

@vittorioromeo
Copy link
Owner

Cool. I am in the process of refactoring and testing #318 BTW, will merge soon

@IvoryDuke
Copy link
Contributor Author

I added a new variable to LevelData to allow level makers to select the 3D mode.
From my testing everything seems to work.

@IvoryDuke IvoryDuke force-pushed the 3D-rendering branch 3 times, most recently from 0d6c73a to 24f3b5a Compare January 28, 2021 15:53
@IvoryDuke IvoryDuke marked this pull request as draft January 31, 2021 19:16
@IvoryDuke
Copy link
Contributor Author

Put this back into draft cause I realized there is a thing that needs to be addressed.

@IvoryDuke IvoryDuke marked this pull request as ready for review February 2, 2021 19:37
@IvoryDuke IvoryDuke force-pushed the 3D-rendering branch 2 times, most recently from 7feba70 to fcdc200 Compare February 8, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants