Allow overwriting all style colors #397
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft as I realized I'll need to add some more stuff and it needs some fixing once #378 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds override colors for every color in a style which is only used if the alpha isn't 0. This way pack developers can specifically overwrite colors in a style which is a much requested feature. Additionally I also added the ability to set the color of single background panels and 3D layers.
I was also thinking about specifying if colors should be used in a different way, but settled for the alpha 0 check as the 3D override color already does this and it still allows transparent colors by having the styles color be transparent and overwriting the rest if really needed (it's an edge case in my opinion).
This PR is also useful for making 1.92 levels android compatible as shaders, which I use to reimplement the old style systems quirks, do not work there at the moment.