Random level/pack selection

[Ena-Shepherd]

• Hitting LeftCtrl will select a random level on your current pack
• LeftCtrl + Focus selects a random pack
• Compatible with favorites

[vittorioromeo]

Thanks for the PR. Not opposed to this feature, just a bit uncomfortable with the hardcoded keys.

[vittorioromeo]

Why are all these checks necessary? Wouldn't the following just always work, or am I missing something?

Suggested change

	int randomLevel;
	if (lvlDrawer->levelDataIds->size() == 1)
	return;
	randomLevel = ssvu::getRndI(0, lvlDrawer->levelDataIds->size());
	if (randomLevel >= lvlDrawer->levelDataIds->size())
	setIndex(0);
	else
	setIndex(randomLevel);
	setIndex(ssvu::getRndI(0, lvlDrawer->levelDataIds->size()));

Ditto for the other two similar functions.

[Ena-Shepherd]

Without the checks, line 1025 sometimes returns what seems to be undefined behavior like "-124852".
This creates an out of bounds error segfault and crashes the program.
Another exception to check is if the pack contains only 1 level, like tutorial pack, or the favorites list.

There is also 2 Keybinds intended to act as the combo keys, but i checked on both Shift Keys instead of Focus, so i will rework on this. (didn't find how to check on Focus directly).

Edit :
Also declared randomLevel and RandomCollection as separated ints in each lambda for better readability.
(3 nested function calls is a bit heavy)

[vittorioromeo]

ssvu::getRndI(a, b) returns a number between a and b-1. So ssvu::getRndI(0, lvlDrawer->levelDataIds->size()) should always give a valid index.

The only case where it can go wrong is if lvlDrawer->levelDataIds->size() == 0, because it can underflow to a very large number. Maybe that's the only required check?

[Ena-Shepherd]

Yes, absolutely.
I'll modify that, and make the keys reassignable and everything should be good :)

[vindowvipre]

Is there any chance you could add a bind for "random level in random pack" too? It is very commonly used in osu, for example.

[Ena-Shepherd]

Is there any chance you could add a bind for "random level in random pack" too? It is very commonly used in osu, for example.

Yes, if @vittorioromeo is ok with that